Replace expired vmware_workstation provider and add other providers to default-config.yml #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig.yml to match provider in Vagrantfile
… default-config.yml
|
Thanks for opening this pull request! Make sure |
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
vmware_workstation is broken as a provider. It needs to be replaced as an example in the default-config.yml file. vmware_desktop correctly loads the latest bento box on VMWare Workstation and VMWare Fusion and is platform agnostic.
vmware_desktop brings the provider in line with the current VVV Vagrantfile and the labels on the bento box used by all of the alt providers: https://app.vagrantup.com/bento/boxes/ubuntu-18.04
The other providers are added as a convenience for hyperv and parallels users and virtualbox just to complete the list of optional providers even though currently it would only override itself.
I realize this is virtually identical to the previous pull request but take your pick: The first one corrects only the provider currently listed there. This is more convenient for all alt provider users. Hopefully growing more relevant as Vagrant grows more provider agnostic.
Checks
developbranch not themasterbranch.